Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/nvui cleanup #16560

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

ui/nvui cleanup #16560

wants to merge 43 commits into from
+625 −816

Conversation

allanjoseph98
Copy link
Member

@allanjoseph98 allanjoseph98 commented Dec 10, 2024 •
edited
Loading

Functional changes:

  • Let users play racingKings and antichess. Only Crazyhouse remains (see Add Crazyhouse to NVUI mode #9125). I would like to see that merged, especially now, considering it is the only remaining variant.
  • Studies: Add buttons to:
    1. Select/change the current chapter.
    2. Edit the current chapter.
    3. Add new chapters
  • Translate some commands using existing translations. No new translation strings were added.

The rest are non-functional changes: refactoring, code golf. Anything else is unintentional bugs.

Closes #16648
Closes #13787
Addresses some of #11185.

@allanjoseph98
use destsToUcis from ui/chess
edf0cdb
@allanjoseph98
move sanToUci to ui/chess
4b11790
@allanjoseph98
change some types
60e0b60
@allanjoseph98
some code golf
686690a
@allanjoseph98
use lichessrules chessops compat util
c26acd4
@allanjoseph98
golf + rename stuff to be more accurate
3dad0fb
@allanjoseph98
remove unused blindmode variants scala set
0e2b7cf
@allanjoseph98
type tweak
cafb9ae
@allanjoseph98
distinguish between cash and non cash variables
08dd1db
@allanjoseph98
rename Style to MoveStyle for clarity
7e6b26b
@allanjoseph98
cast type directly
1c067b8
@allanjoseph98
use roles const from chessops
2f36dac
@allanjoseph98
refactor
730a5f8
@allanjoseph98
programatically render choice examples
410d118
@allanjoseph98
fix order
e5cd01d
@allanjoseph98
some weight loss
fbd6d0e
@allanjoseph98
sanToWords util func.
28d1180 
Strike down the tower of babel
@allanjoseph98
remove unused constructor parameter
1a803a5
@allanjoseph98
golf
21c1cc7
@allanjoseph98
correct lichess comment Regex
036ca3c
@allanjoseph98
fix game start
f242042
@allanjoseph98
allow racingKings and antichess in nvui
79750ae
@allanjoseph98
refactor
f82f82c
@allanjoseph98
golf puzzle nvui
894dac0
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 17, 2024
View reviewed changes
ui/nvui/src/chess.ts Show resolved Hide resolved
@schlawg
Copy link
Collaborator

schlawg commented Dec 17, 2024

great stuff

@allanjoseph98
Copy link
Member Author

Gonna stop myself for now so that future bug fixing can be a bit more manageable

@allanjoseph98 allanjoseph98 marked this pull request as ready for review January 4, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlawg schlawg schlawg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@allanjoseph98 @schlawg